Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datasets with jets #13

Open
cschwan opened this issue Feb 14, 2022 · 8 comments
Open

Fix datasets with jets #13

cschwan opened this issue Feb 14, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@cschwan
Copy link
Contributor

cschwan commented Feb 14, 2022

In Madgraph5_aMC@NLO v3.3.1 the cutting routine was changed, so that pjet isn't calculated in the place where we use it anymore. We either have to 1) run the jet algorithm ourselves or 2) move jet-related custom cuts from passcuts_user to passcuts_jets in cuts.f.

@cschwan cschwan added the bug Something isn't working label Feb 14, 2022
@alecandido
Copy link
Member

I've not a perfect understanding, but to me seems like option 1) is sufficiently more complicated than 2) (do we need to run an extra step in the runner? do we need to embed the fortran/python code?).

Option 2) looks like something I can do with sed in the cuts_code folder (plus moving the place where code is injected, maybe...).
Probably I'm really not understanding something...

@cschwan
Copy link
Contributor Author

cschwan commented Feb 15, 2022

I like option 2 better than 1, because it's faster as you said, but it requires some non-trivial adjustments. We need to essentially sort our custom cuts according to jet cut/non-jet cuts, and then write them into different functions in cuts.f.

@alecandido
Copy link
Member

We can simply split them in two folders (the natural way to create scopes on filesystem).

We can split by hand, they are not that many (and we should check we are choosing them correctly).
However, just to point it out, I believe there is simple rule to decide if it's a jet cut or not: "if it contains at least a j in the file name it's a jet, otherwise it is not".

@cschwan
Copy link
Contributor Author

cschwan commented Feb 16, 2022

@alecandido I'm a bit unhappy about the fact that Madgraph5 changed this; a possible problem that I see is that there are cuts that concern jets and leptons at the same time, meaning that we can't separate them, and I wonder if it isn't a better choice to rewrite the cutting routine slightly so that we don't have to change our cuts.

@alecandido
Copy link
Member

I'm not an expert of mg5 internals, but if you feel like of course you can have a try, and I can just review it :)

@alecandido
Copy link
Member

@cschwan I'm not sure if this is 100% related to the MadGraph pinecards, or I should transfer to pinefarm. But maybe you know.

@cschwan
Copy link
Contributor Author

cschwan commented Dec 15, 2022

This concerns the code that patches/runs Madgraph, so I suppose it should go to pinefarm.

@cschwan
Copy link
Contributor Author

cschwan commented Dec 15, 2022

This concerns the implementation of patches/cut in Madgraph, so it should be a pinefarm issue.

@alecandido alecandido transferred this issue from NNPDF/pinecards Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants