[Filter] Clear & explicit error for missing extensions. #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an extension (e.g., nnstreamer-tensorflow) is missing, the error message must be explicit and visible even without GST_DEBUG envvars; most applications developers won't know it. However, we cannot alarm them at the stage of set-properties. Thus, delay alarming until it becomes "fatal". Fixes nnstreamer#1206 Helps https://github.com/nnsuite/nnstreamer-example/issues/21 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo
requested review from
again4you,
helloahn,
jaeyun-jung,
jijoongmoon,
kparichay,
leemgs,
wooksong and
a team
as code owners
|
📝 Version: 1.20190225. Thank you for submitting PR #1207. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/. |
jaeyun-jung
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an extension (e.g., nnstreamer-tensorflow) is missing,
the error message must be explicit and visible even without
GST_DEBUG envvars; most applications developers won't know it.
However, we cannot alarm them at the stage of set-properties.
Thus, delay alarming until it becomes "fatal".
Fixes #1206
Helps https://github.com/nnsuite/nnstreamer-example/issues/21
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Self evaluation: