Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using pandas dataframe as datatype instead of mapping 2D arrays and names #73

Open
hellkite500 opened this issue Apr 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@hellkite500
Copy link
Member

def __init__(self, catchment: Catchment, range_start: datetime, range_end: datetime, data: np.ndarray,

At first glance, class appears to be replicating some basic functionality of a Pandas DataFrame, i.e. labeled 2D array. Unless there is some serious flaw in doing so, we an replace these inputs with a DataFrame.

@robertbartel robertbartel added the enhancement New feature or request label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants