Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating values as individual attributes and as part of a dictionary (_values). Choose one. #5

Closed
jmframe opened this issue Sep 21, 2021 · 0 comments · Fixed by #31
Assignees

Comments

@jmframe
Copy link
Contributor

jmframe commented Sep 21, 2021

Short description explaining the high-level reason for the new issue.

Current behavior

Storing values as individual attributes of the BMI model:
self.total_precipitation or self.atmosphere_water__liquid_equivalent_precipitation_rate
And as part of a dictionary:
self.all_lstm_input_values_dict['atmosphere_water__liquid_equivalent_precipitation_rate']

Expected behavior

Just store the value in one place or another.
Also, we don't need the dictionary all_lstm_input_values_dict, we'll just include everything in _values

jmframe added a commit that referenced this issue Sep 23, 2021
@madMatchstick madMatchstick self-assigned this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants