Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement byteBlock as class #13

Closed
3 tasks done
noah1510 opened this issue Aug 17, 2020 · 1 comment
Closed
3 tasks done

implement byteBlock as class #13

noah1510 opened this issue Aug 17, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Open Projects status
Milestone
v2.0.0

Comments

@noah1510
Copy link
Owner

noah1510 commented Aug 17, 2020 •
edited
Loading

byteBlock should be a class to allow it being a return type, reducing the need of C-style arguments (pointer to return location as argument).

  • create byteBlock class that simply replaces the current array
  • replace or add new functions with byteBlock as return type
  • implement it to have index 0 as top row of a segment I think it is best to not change this, since it would break compatiblility with older version.
@noah1510 noah1510 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 17, 2020
@noah1510 noah1510 added this to the v2.0.0 milestone Aug 17, 2020
@noah1510 noah1510 added this to Needs triage in Open Projects status via automation Aug 17, 2020
@noah1510 noah1510 moved this from Needs triage to High priority in Open Projects status Aug 17, 2020
noah1510 added a commit that referenced this issue Dec 19, 2020
@noah1510
adding byteblock class #13
09251f4
noah1510 added a commit that referenced this issue Dec 19, 2020
@noah1510
added function that return ByteBlock as type #13
676cf2e
@noah1510
Copy link
Owner Author

the old functions will be removed in version 2.2.0

Open Projects status automation moved this from High priority to Closed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Open Projects status
  
Closed
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@noah1510