Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't read entire entire file into memory #201

Closed
dufferzafar opened this issue Jun 19, 2022 · 4 comments
Closed

Don't read entire entire file into memory #201

dufferzafar opened this issue Jun 19, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dufferzafar
Copy link

One of the property of pagers like less is that they are memory bounded by default, so they don't read the entire file into memory and can easily be used on huge files (say 100s of GBs)

Looking at less source code, this doesn't seem trivial to implement.

But this would be a great win for ov!
@dufferzafar dufferzafar changed the title Don't read entire file into memory Don't read entire entire file into memory Jun 19, 2022
@noborus
Copy link
Owner

noborus commented Jun 19, 2022

Thank you.
The policy is different from less, but I will consider the upper limit.

@noborus noborus added enhancement New feature or request good first issue Good for newcomers labels Jun 19, 2022
@ILoveGoulash
Copy link

Could just mmap, no?

@noborus noborus mentioned this issue Mar 7, 2023
Merged
@noborus
Copy link
Owner

noborus commented May 6, 2023

Implemented in v0.20.0. Please give it a try.
(This release may be unstable.)

@noborus
Copy link
Owner

noborus commented May 31, 2023

I officially released v0.30.0. This has been resolved.

@noborus noborus closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dufferzafar @noborus @ILoveGoulash