Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation Command Filtering #2

Open
datcomputerguy opened this issue Jun 28, 2017 · 2 comments
Open

Conversation Command Filtering #2

datcomputerguy opened this issue Jun 28, 2017 · 2 comments

Comments

@datcomputerguy
Copy link
Contributor

Need to work on the syntax that pulls commands from the returned conversation text. Currently using ~ACTION but I am thinking we need to do something with the tag syntax
<tj action="LED">
or
<tj action="LED" color="RED"><tj action="SPEAK">TURN LIGHT ON, SPEAK THIS, AND THEN TURN LIGHT OFF></tj></tj>

That way actions can be triggered in the code that last a duration but the programmer doesn't actually have to know the duration of the inner action. And if another action is called it always trumps, basically how we have the treads working right now.

@datcomputerguy
Copy link
Contributor Author

This would also allow for easy pulling of parameters and it not requiring text.

@datcomputerguy
Copy link
Contributor Author

datcomputerguy commented Jun 28, 2017

This could also be connected to the Python code by using the action text to make a (im not sure what it is called) but basically attempt to connect the text to a function inside of the program instead of using the large if then if then block to interpret the commands. This way the new commands will just work and they won't have to be added to the interpreter, it will attempt to run the command and if it can't then it says so or something.

THIS DOES OPEN THREATS we will need to make sure that certian methods cannot be called using this syntax such as direct system calls as processes, threads, subprocesses, etc. exit(), forks, etc. They will need to be limited to actions in the objects and not have access to the __METHOD__ methods as they should be "private"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant