-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we need some way of counting CLAMour support #252
Comments
The original intent had been to avoid parsing it at all in client. It isn't by any stretch heavy lifting, and I am not against it, but we should be extra careful to make sure nothing can be exhausted or stressed. Lighter == Better. |
The fact that the end result ended up being a count over a window, that relieves most of those concerns, I think. Anything beyond the window can simply be dropped, which leaves us with a limited set of data to which even exponential complexity shouldn't be a problem. |
But it's a rolling window isn't it? ie. blocks 700000 to 709999, That's what a rolling window is - and so needs to be constantly monitored to see if it every crosses the threshold. I wrote the above after only seeing your 2nd comment. It's probably best disregarded. I would delete it, but I guess it has already been emailed to you... |
Until recently I've assumed it could be done with a sort of blockchain parser or explorer. But it seems more peer-oriented to make the measurements consistently repeatable via the core client. I'm not sure how the client should keep track of those measurements though. |
@Kefkius in-chain data is in-chain data; if the 'measurements' aren't 'consistent' and 'repeatable' then we have bigger problems than CLAMour :) That said, I am not against having all of this functionality in the client. @dooglus The fact that the petition process was created as a rolling window negates this largely. |
Now that we have people actively supporting CLAMour petitions, we need a way of counting the support, and logging and/or alerting when support for any petition crosses a threshold.
Is anyone working on code to do this?
I figure we want something similar to the stakenotify= clam.conf setting, but am not sure what's best.
The point is that support for a petition may hit 75% (or whatever the trigger point for 'success' is) at some point when nobody's looking, and then fall back again. The client should notice this happening and log (or notify) us about it.
The text was updated successfully, but these errors were encountered: