removeInterceptor with scope as an argument.

[dpc]

It's very easy to mistakenly pass a scope to removeInterceptor and not be aware it's wrong.

First the difference between interceptor and scope is not explained at all in the README, as far as I can tell.

Second, after passing scope to removeInterceptor it actually returns true, even though it does not remove a single item. true is returned unconditionally here: https://github.com/node-nock/nock/blob/11f1a25ee88b0328c92070e4749793902907a60d/lib/intercept.js#L219 no matter if there was a single match in the inner loop just above it, or not.

It seems to me that passing a scope should just work, and be handled correctly (by removing all interceptor from the scope).

[adarrra]

I also couldn't understand why 'removeInterceptor' didn't work for me... And then I understood that

var interceptor = nock('http://example.org').get('somePath');
var scope = interceptor.reply(200)

So issue helped. Don't want to look silly but it was not clear from docs for me.

[gr2m]

Thanks Adara for letting us know. We plan to invest some time to improve the documentation soon, so this is timely and valuable input :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!