Calling nock.restore() after each test suite doesn't stop memory leak

[yuchenQ]

What is the expected behavior?

Hi there, I am a jest user.

  beforeEach(() => {
    if (!nock.isActive()) {
      nock.activate();
    }
  });

  afterEach(() => {
    nock.cleanAll();
    nock.restore();
  });

calling this block should stop memory leak.

What is the actual behavior?

When I checkout the heap size usage by running node --expose-gc ./node_modules/.bin/jest --runInBand --logHeapUsage <DIR>
I can still see the heap size gradually increased around 30MB after finishing a test file until it reached to the limit of memory capacity by V8 and shutdown the testing process.

Possible solution

Please if some of you resolved this leak by using nock.store, share what exactly you do, I do really appreciate it.

How to reproduce the issue

Runkit: Example link

Having problem producing a test case? Try and ask the community for help. If the test case cannot be reproduced, the Nock community might not be able to help you.

Does the bug have a test case?

Versions

Software	Version(s)
Nock	13.0.4
Node	12.18.3
TypeScript

[mastermatt]

What makes you think the leak if caused by Nock in your case? Is it possible the leak is coming from elsewhere?

[yuchenQ]

What makes you think the leak if caused by Nock in your case? Is it possible the leak is coming from elsewhere?

You are definitely right, and I made an experiment which comments one dependency each time and then checks out whether the leak still exists or not, at last, we found the culprit is the usage of the nock.

And there are some issues already which pointed out the leak case. The intent of this issue is to get ideas if possible from people who suffered from this leak and fixed it by using nock.store or something else.

[paulmelnikow]

Could you provide a minimal example repo which exhibits the leak?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[adamchenwei]

Why this is closed? I am also still experiencing this issue!

[mastermatt]

@adamchenwei no one was able to provide a minimal example repo which exhibits the leak. We've yet to see actual confirmation that there is a memory leak. I'm not saying there isn't one, but several of us have tried to reproduce it without success. Any insight you can provide from your issues are welcome.

[RedTn]

@mastermatt

I have recreated the issue here: https://github.com/RedTn/nock-memory-leak

node: 16.10.0
nock: 13.2.8

Let me know if this works for you, I'm running into the exact same issue.
Else I can just make a new issue and reference this

[gr2m]

Else I can just make a new issue and reference this

that would be preferable, thank you! Thank you for creating the repository to reproduce the issue, very helpful!