fix(intercept): handle global flags during regexp matching #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When matching via a regexp instance, consistently test the entire target string. Sets the `lastIndex` to zero for cases where the `global` flag is set and the regexp instance has been tested previously. fixes: nock#2134
mastermatt
force-pushed
the
2134-global-regexp
branch
from
4e25b9d
to
ea2194c
Compare
gr2m
approved these changes
Jan 20, 2021
Comment on lines
+420
to
+421
| // if the regexp happens to have a global flag, we want to ensure we test the entire target | ||
| pattern.lastIndex = 0 |
|
🎉 This PR is included in version 13.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
uxmaster
added a commit
to uxmaster/nock
that referenced
this pull request
Jan 21, 2021
fix(intercept): handle global flags during regexp matching (nock#2135)
This was referenced Mar 8, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching via a regexp instance, consistently test the entire target string.
Sets the
lastIndexto zero for cases where theglobalflag is set and the regexp instance has been tested previously.fixes: #2134