fix(playback): consistently check for destroyed attribute
#2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node, as of 14.1, started migrating the Client Request terminology from `aborted` to `destroyed`. In order to supported our current Node version support, 10.x+, we need to check both flags. Nock was already doing this in the router, but not during playback.
mastermatt
force-pushed
the
2146-req-destroyed
branch
from
d3762c4
to
b8629dc
Compare
gr2m
approved these changes
Feb 26, 2021
| * | ||
| * @param {ClientRequest} req | ||
| * @returns {boolean} | ||
| */ |
There was a problem hiding this comment.
love all the context in the comment 👏
There was a problem hiding this comment.
Same! Thank you, @mastermatt.
|
🎉 This PR is included in version 13.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node, as of 14.1, started migrating the Client Request terminology from
abortedtodestroyed. In order to supported our current Node versionsupport, 10.x+, we need to check both flags. Nock was already doing this
in the router, but not during playback.
Identified from #2146