Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #2529

Merged
merged 2 commits into from Oct 19, 2023
Merged

remove lodash #2529

merged 2 commits into from Oct 19, 2023

Conversation

Uzlopak
Copy link
Member

@Uzlopak Uzlopak commented Oct 17, 2023

Closes #2530

This PR removes lodash with equivalent functionality.

This was referenced Oct 17, 2023
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everytime nock needed to update lodash was because of some sec. vuln

there is another side to the coin. lodash implements a ton of edge cases that we don't need to worry about and continuously adds improvements. Once we eject it, we will miss out on that and the same sec. vuln that we would be notified about will just exist in nock and we probably won't know.

In this case I'm okay ejecting it though, we don't use much of it, the benefits outweigh the disadvantages.

Thank you for contributing to @nock 💐

@gr2m gr2m merged commit 7bfcb31 into nock:main Oct 19, 2023
19 checks passed
@gr2m
Copy link
Member

gr2m commented Oct 19, 2023

@all-contributors please add @Uzlopak for code, test, and maintenance

@allcontributors
Copy link
Contributor

@gr2m

I've put up a pull request to add @Uzlopak! 🎉

@github-actions
Copy link

🎉 This PR is included in version 13.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lodash
2 participants