fix: fetch response status text #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Feb 13, 2024
| @@ -37,7 +38,7 @@ function createResponse(message) { | |||
|
|
|||
| return new Response(responseBodyOrNull, { | |||
| status: message.statusCode, | |||
| statusText: message.statusMessage, | |||
| statusText: STATUS_CODES[message.statusCode], | |||
There was a problem hiding this comment.
why not?
Suggested change
| statusText: STATUS_CODES[message.statusCode], | |
| statusText: message.statusMessage || STATUS_CODES[message.statusCode], |
There was a problem hiding this comment.
@Uzlopak I'm not against adding this, but from what I see, we never set this, so it will always be null
There was a problem hiding this comment.
I'd say if STATUS_CODES[message.statusCode] passes all our tests, I'd go with that.
There was a problem hiding this comment.
small note: This is fetch-only code, so we don't have a big coverage here.
gr2m
approved these changes
Feb 17, 2024
|
🎉 This PR is included in version 14.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2397 (comment)