fix: replace debug with node debug

[Uzlopak]

I did not fix the unit test as I could not fix it properly. But lets discuss this.

[Uzlopak]

Just one remark, which I realized later:

debuglog does not exist on browsers. So if we have the necessity to support browsers, it wont work. But I think the support of browsers got lost few major versions ago?

[mikicho]

@Uzlopak I don't think we support Browser (I think because we use setImmdeiate for example). But if (when?) we complete this effort, we may want to support browsers as well.

[Uzlopak]

Well, i dont know why for browsers nock should be used, but i wanted to say, why maybe debug was used in the first place.

[mikicho]

@Uzlopak why not? MSW is very popular in the browser.

[gr2m]

I wouldn't worry about browsers for now. When we get there we can use ESM features to give non-nodejs environments a different implementation of debug that works in browsers.

[Uzlopak]

@mikicho @gr2m
PTAL

[mikicho]

@Uzlopak What is the problem with the tests?

[Uzlopak]

added test.

[gr2m]

Changes look great, thank you for adding tests!

Not sure about the ERR_INVALID_ARG_TYPE CI error, I've seen that in other PRs as well 😞

[Uzlopak]

Rerunning the tests and it run through

[gr2m]

@mikicho if changes look good to you, let's merge

[mikicho]

LGTM

[github-actions]

🎉 This PR is included in version 14.0.0-beta.5 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀