Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream file on replyWithFile #49

Closed
fent opened this issue Mar 13, 2012 · 4 comments
Closed

Stream file on replyWithFile #49

fent opened this issue Mar 13, 2012 · 4 comments
Assignees
@pgte
Labels
feature

Comments

@fent
Copy link
Contributor

fent commented Mar 13, 2012

It would be more efficient if instead of buffering the entire file contents in sync, nock would stream the file through response.

Response could be truly pipeable. Currently it only emits one data event.
@pgte
Copy link
Member

pgte commented Mar 14, 2012

Agree, will experiment on that.

@ghost ghost assigned pgte Mar 16, 2012
@pgte
Copy link
Member

pgte commented Mar 19, 2012

nock v0.11.1 now does that, check it out if you can :)

@pgte pgte closed this as completed Mar 19, 2012
@fent
Copy link
Contributor Author

fent commented Mar 19, 2012

Yes!

Thanks @pgte :)

@lock
Copy link

lock bot commented Sep 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pgte pgte

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgte @fent