Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect verbs when generating recordings #93

Closed
andrerod opened this issue Feb 21, 2013 · 2 comments
Closed

Incorrect verbs when generating recordings #93

andrerod opened this issue Feb 21, 2013 · 2 comments

Comments

@andrerod
Copy link

Right now recordings generate code that, among other things, include a builder pattern with a function that is named after the HTTP verb. The problem is that the scope may not support that verb.

E.g.:

nock('http://ciserversdk.table.core.windows.net:80')
.filteringRequestBody(function (path) { return '';})
.merge('/tableservice12(PartitionKey=%27part1%27,RowKey=%27row1%27)', '
')
.reply(204, "", { 'cache-control': 'no-cache',
'content-length': '0',
date: 'Thu, 21 Feb 2013 00:30:56 GMT' });

A better solution would be to generate (at least for the ones that are not trivial / supported) the recordings with a generic http verb processing mechanism.

Example:

.request('merge', 'tableservice12' foobar)
.reply(foobar)

@pgte
Copy link
Member

pgte commented Dec 3, 2013

Closing this one, if this is still an issue please reopen.
Thanks!

@pgte pgte closed this as completed Dec 3, 2013
@lock
Copy link

lock bot commented Sep 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants