Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敠 Feature: Percent Type #4457

Open
1 task done
wingkwong opened this issue Nov 22, 2022 · 1 comment
Open
1 task done

馃敠 Feature: Percent Type #4457

wingkwong opened this issue Nov 22, 2022 · 1 comment
Labels
馃敠 Type: Feature New functionality is requested.
Milestone

Comments

@wingkwong
Copy link
Member

wingkwong commented Nov 22, 2022

Please confirm if feature request does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the usecase for the feature

It was partially implemented but got reverted during UI migration. Now it's good to bring it back.

References:

Suggested Solution

We can reuse the previously code.

Percent Cell:
https://github.com/nocodb/nocodb/pull/2910/files

Percent Column:
https://github.com/nocodb/nocodb/pull/3017/files

Additional Context

we may need to think about the migration.

@dstala dstala added the 馃敠 Type: Feature New functionality is requested. label Dec 2, 2022
@dstala dstala added this to the vNext milestone Nov 1, 2023
@dstala dstala modified the milestones: v0.202.6, vNext Nov 13, 2023
@wingkwong wingkwong modified the milestones: v0.202.10, v0.203.0 Dec 14, 2023
@dstala dstala removed this from the vFeature milestone Dec 19, 2023
@dstala dstala added this to the Q1 milestone Jan 17, 2024
@rameshmane7218 rameshmane7218 self-assigned this Feb 8, 2024
@rameshmane7218
Copy link
Collaborator

rameshmane7218 commented Feb 9, 2024

  • Show percent field GroupBy label as cell display value
  • Don't show progress in GroupBy label insted show percent
  • Fix pw test cases
  • Add Percent column suggestion in Formula suggestionsList which will clearly describe that the percent field value stored in db is cellValue/100. e.g: cellValue=25 but in db value will be stored as 0.25 and in formula it will be used as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃敠 Type: Feature New functionality is requested.
Projects
Status: 馃殽 Open : On Hold
Development

No branches or pull requests

3 participants