Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Values in currency fields are not saved [Firefox] #6086

Closed
1 task done
djmaze opened this issue Jul 27, 2023 · 10 comments · Fixed by #7581
Closed
1 task done

🐛 Bug: Values in currency fields are not saved [Firefox] #6086

djmaze opened this issue Jul 27, 2023 · 10 comments · Fixed by #7581
Assignees
Labels
🐛 Type: Bug Something is broken or incorrect unexpectedly.
Milestone

Comments

@djmaze
Copy link
Sponsor Contributor

djmaze commented Jul 27, 2023

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

  1. Create a new table, add a currency field (settings do not matter).
  2. Enter a record and add a value in the currency field.
  3. Refresh the table.
  4. See that the currency value is gone.

In the network inspector, I can see that changing the field does not even trigger a request (as opposed to changing other fields in the record).

Desired Behavior

Well.. The field should be saved of course.

Project Details

Node: **v16.20.0**
Arch: **x64**
Platform: **linux**
Docker: **true**
RootDB: **pg**
PackageVersion: **0.109.4**

Attachments

No response

@djmaze djmaze changed the title 🐛 Bug: Currency field is not saved 🐛 Bug: Values in currency fields are not saved Jul 27, 2023
@wingkwong
Copy link
Member

I couldn't reproduce the issue (tried different Currency Locale & Currency Code).

  • Can you try the same steps on the new table to see if you can reproduce the issue?
  • Can you try adding values to other field types to see if they can be saved or not?
  • Any specific errors you can find in the log?

image

@shashankvish0010
Copy link

shashankvish0010 commented Jul 27, 2023

I cannot reproduce the issue, even after refreshing the page the currency value is there.

@djmaze
Copy link
Sponsor Contributor Author

djmaze commented Jul 27, 2023

Turns out this is (again, I experienced this before) a Firefox-specific problem. It works for me in Chromium and Brave, but not in Firefox (105.0).

@wingkwong wingkwong added the 🐛 Type: Bug Something is broken or incorrect unexpectedly. label Jul 28, 2023
@wingkwong
Copy link
Member

@djmaze Thanks for the info. Now I can reproduce the issue on Firefox.

@distresscode
Copy link

I'm experiencing the same in Firefox. The behavior is similar to issue #4329

App/Server: NocoDB 0.109.5 via Cloudron 7.5.0 on Ubuntu 22.04.

@dstala dstala changed the title 🐛 Bug: Values in currency fields are not saved 🐛 Bug: Values in currency fields are not saved [Firefox] Aug 3, 2023
@johnmpost
Copy link

I am having the exact same issue

@wingkwong
Copy link
Member

preliminary findings:

  • submitCurrency is fired when it is blurred (e.g. click outside the cell) as expected
  • submitCurrency is not fired when pressing enter (in firefox only)

@alexgtn
Copy link

alexgtn commented Nov 11, 2023

same here

@Erudition
Copy link

Tried clicking outside of the field instead but it's not saved either.
Tried in Chromium and I get an error popup, Record update failed a.includes is not a function.

@davidbgk
Copy link

Confirmed with Firefox 121, the content is not saved if you press Enter but it might save the number if you Tab into another cell. Note that it doesn't work every time so beware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something is broken or incorrect unexpectedly.
Projects
Status: ✅ Closed
Development

Successfully merging a pull request may close this issue.

9 participants