Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: Setting any incorrect column name, resulting in erroneous deletion of data #6342

Closed
1 task done
starmisszhang opened this issue Sep 9, 2023 · 2 comments 路 Fixed by #6770
Closed
1 task done
Assignees
Labels
馃悰 Type: Bug Something is broken or incorrect unexpectedly.
Milestone

Comments

@starmisszhang
Copy link

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

REST APIs
Bulk delete with conditions

There is a timestamp column in the database. When I tried conditional deletion, I accidentally entered the column name incorrectly, which caused the data to be accidentally deleted,

where=(111timestamp,eq,1694257034)
杈撳叆閿欒鐨勫垪鍚嶄负:111timestamp

Desired Behavior

This problem has brought a lot of troubles, and I hope to be able to handle it

Project Details

NocoDB used as docker : true

Attachments

screenshot20230909
image

@wingkwong wingkwong added the 馃悰 Type: Bug Something is broken or incorrect unexpectedly. label Sep 10, 2023
@wingkwong
Copy link
Member

similar to #6081 but in DELETE.

@dstala
Copy link
Member

dstala commented Oct 21, 2023

@pranavxc i believe we ignore incorrect filters with incorrect field name, leading to this behaviour. let us fix this to return error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Type: Bug Something is broken or incorrect unexpectedly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants