Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敠 Feature: Filter Days now uniformly utilizes 'datetime' for all calculations. #7176

Closed
1 task done
emre1e opened this issue Dec 6, 2023 · 3 comments
Closed
1 task done
Labels
馃攷 Status: More Info Needed More information is required to figure out the root cause.

Comments

@emre1e
Copy link

emre1e commented Dec 6, 2023

Please confirm if feature request does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the usecase for the feature

Current Functionality:
The existing filter displays all entries occurring after the specific date and time:

where(2023-12-05 13:30:00+00:00,ge,today)
In this case, all events after '2023-12-05 13:30:00+00:00' are shown.

image

Suggested Solution

New Functionality:
The proposed filter will display all entries occurring after the specific date, disregarding the time:

where(2023-12-05 13:30:00+00:00,geDate,today)
With this, all events after '2023-12-05 00:00:00+00:00' will be displayed, irrespective of the time.

Additional Context

Node: v18.18.2
Arch: x64
Platform: linux
Docker: true
RootDB: pg
PackageVersion: 0.202.9-20231204-1203

@dstala
Copy link
Member

dstala commented Dec 6, 2023

@emre1e can you help us understand purpose of this change proposal? if we wish to disregard time, is it not good idea to switch over to date type instead of date time?

@dstala dstala added the 馃攷 Status: More Info Needed More information is required to figure out the root cause. label Dec 6, 2023
@emre1e
Copy link
Author

emre1e commented Dec 7, 2023

@dstala this are appointment and must be in datetime. I have no option to see all appointment from yesterday. Its always using the time too.

Maybe we could create a new formula to convert datetime to date and i can use it in the filter?

@dstala dstala unassigned o1lab Dec 8, 2023
@emre1e
Copy link
Author

emre1e commented Dec 11, 2023

@dstala i think this #7189 fixed it.

@emre1e emre1e closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃攷 Status: More Info Needed More information is required to figure out the root cause.
Projects
None yet
Development

No branches or pull requests

3 participants