Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse failure with AM designator as leading substring of PM designator #201

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Closed
Labels
bug
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Suppose you have a culture with an AM designator of "Foo" and a PM designator 
of "FooBar". Currently if we format 4pm as "4 FooBar" and then try to parse it, 
we'll parse the "4 Foo" and then think we've finished.

We should do the longest-match as per other text fields such as month and day 
of week.

Original issue reported on code.google.com by jonathan.skeet on 23 Mar 2013 at 9:40

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 32ff9cbc4b26.

Original comment by jonathan.skeet on 23 Mar 2013 at 9:42

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Was this only a theoretical problem, or are there actual cultures that behave 
like this?

Original comment by malcolm.rowe on 23 Mar 2013 at 10:37

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

It's a real problem in Mono 3.0, in Cambodia IIRC (definitely some culture). 
I'd never have spotted it otherwise, but I wanted to make sure we tested it 
either way :)

Original comment by jonathan.skeet on 24 Mar 2013 at 3:16

@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.1.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants