You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OffsetDateTimePattern is missing some methods. It only has one .Create(),
while other patterns like LocalDateTimePattern have two overloads of .Create(),
and .CreateWithInvariantCulture() and .CreateWithCurrentCulture().
Original issue reported on code.google.com by mj1856 on 22 Jan 2014 at 10:40
The text was updated successfully, but these errors were encountered:
It looks like these are inconsistent on the other patterns as well. There may
be a few where CurrentCulture doesn't make sense, but we should be as
consistent as possible across the different pattern types.
Original comment by mj1856 on 22 Jan 2014 at 10:41
I tried to do a bit of a tidy-up before 1.2, but OffsetDateTimePattern
definitely needs improving. (I noticed that myself on a previous SO question.)
There's also inconsistency in terms of the naming of the pre-canned patterns,
but there are usually good reasons for that (where the alternatives wouldn't
make much sense). We definitely need to balance consistency and sense, of
Original comment by jonathan.skeet on 23 Jan 2014 at 6:59
Changed title: Support more Create* methods on OffsetDateTimePattern
Before calling this done, perhaps we should add culture-aware versions of the
standard format patterns?
Also, it seems strange that OffsetDateTimePattern doesn't have culture-aware
patterns but OffsetPattern does. One would think that the same patterns that
work in LocalDateTimePattern would work in OffsetDateTimePattern. But I can't
think of any cases where formatting an Offset in any culture would yield a
different result than in the invariant culture.