Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to JS standard #305

Closed
tusharmath opened this issue Apr 8, 2016 · 6 comments
Closed

Migration to JS standard #305

tusharmath opened this issue Apr 8, 2016 · 6 comments

Comments

@tusharmath
Copy link

Hi,
StandardJS is a pretty decent tool for avoiding all the bikeshedding related to linting JS projects.

I observed that there is no .eslintrc in the project nor are there any guidelines as to what is being currently followed. It would be great if we could just simply migrate to standard because adding changes right now creates way too many linting errors on my IDE (webstorm) and I am sure it happens with other devs as well.

Thanks.

@markstos
Copy link
Collaborator

markstos commented Apr 8, 2016

This is the first time this has come up. You are welcome to create a PR that passes all the StandardJS checks so we can see what the differences look like.

@tusharmath
Copy link
Author

Alright, this is a lot of work, let me give it a shot.

@vroudge
Copy link

vroudge commented Apr 15, 2016

Hello,

Just dropping by to say that StandardJS is not the standard at all as of now. The JS community has outbursted a lot against the owner of the repo which tries to imply that some choices on the JS coding style he's done in his repo are standard. Wink wink semicolons.

One should refer to https://github.com/airbnb/javascript, for instance, or any other styleguide and its linter that are actually serious, that are considered much more knowlegeable in the industry.

Thanks for config, by the way, love it.

@tusharmath
Copy link
Author

@vroudge I can not disagree with you here. feross/Standard apparently is more popular and its easy to get started with it because of the variety of tools that are already available. I think a better solution would be to add a .eslintrc file instead for this project.

@vroudge
Copy link

vroudge commented Apr 16, 2016

Airbnb-styleguide, for instance, is muuuuuuch more popular than Standard. No possible doubt, just check the npm packages for ESLint downloads/month, or just the stars on the github repo. 👍

@tusharmath
Copy link
Author

@vroudge I had not seen the stars/forks on github. Nevertheless, you have solid point and that's why I created #310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants