Outdated vows in node_modules

[fredreichbier]

Hi again! :)

Looking into the node-config tests, I noticed that npm test doesn't work for me. I'm running node.js 0.6.1and get an error like this:

% npm test          

> config@0.4.5 test /home/fred/dev/node-config
> ./node_modules/vows/bin/vows test/*.js --spec


node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
Error: require.paths is removed. Use node_modules folders, or the NODE_PATH environment variable instead.
    at Function. (module.js:376:11)
    at Object. (/home/fred/dev/node-config/node_modules/vows/bin/vows:37:8)
    at Module._compile (module.js:432:26)
    at Object..js (module.js:450:10)
    at Module.load (module.js:351:31)
    at Function._load (module.js:310:12)
    at Array.0 (module.js:470:10)
    at EventEmitter._tickCallback (node.js:192:40)
npm ERR! config@0.4.5 test: `./node_modules/vows/bin/vows test/*.js --spec`
npm ERR! `sh "-c" "./node_modules/vows/bin/vows test/*.js --spec"` failed with 1
npm ERR! 
npm ERR! Failed at the config@0.4.5 test script.
npm ERR! This is most likely a problem with the config package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./node_modules/vows/bin/vows test/*.js --spec
npm ERR! You can get their info via:
npm ERR!     npm owner ls config
npm ERR! There is likely additional logging output above.
npm ERR! 
npm ERR! System Linux 3.1.1-1-ARCH
npm ERR! command "node" "/usr/bin/npm" "test"
npm ERR! cwd /home/fred/dev/node-config
npm ERR! node -v v0.6.1
npm ERR! npm -v 1.0.104
npm ERR! code ELIFECYCLE
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/fred/dev/node-config/npm-debug.log
npm not ok

The vows version in node_modules seems to be 0.5.8, which seems to cause these problems. I just rm -rfed node_modules and did npm install, which gave me vows 0.5.13, everything works then. :)

[lorenwest]

Hi Fredreich,

Thanks for the heads up. I have yet to install node 0.6.x, so I will try this and validate that it doesn't break anything in node 0.4.x.

It sounds like there's a good workaround until this change gets pushed.

Cheers,
-Loren

ps: require.paths was pure evil, and I'm glad they removed it in 0.6.

[DamonOehlman]

Loren,

Is it worth considering moving vows into the "devDependencies" section in the package.json file too?

Cheers,
Damon.

[lorenwest]

Hi Damon,

Vows is required to test the install. If it were placed into devDependencies, then it wouldn't be installed by default and the tests would fail.

I'd rather fix the tests than not have them installed.

-Loren

[lorenwest]

Updated vows to 0.5.13, and verified it still works with node 0.4.8