Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "actual size" in error message for content size check #1350

Closed
dylanbussone opened this issue Oct 25, 2021 · 1 comment
Closed

Include "actual size" in error message for content size check #1350

dylanbussone opened this issue Oct 25, 2021 · 1 comment
Labels

Comments

@dylanbussone
Copy link

dylanbussone commented Oct 25, 2021

Problem:

The current error message for content size is merely

`content size at ${data.url} over limit: ${data.size}`

where data.size is the limit. It gives no indication of how much bigger the actual size was than the limit, which is valuable information.

Request:

Include the actual size in the error message in addition to the limit.
I have a local branch with this addition, if you give me permissions I'd be happy to open a PR.

@jimmywarting
Copy link
Collaborator

I'm having thoughts on deprecating/removing size option...

@node-fetch node-fetch locked and limited conversation to collaborators Jan 16, 2022
@jimmywarting jimmywarting converted this issue into discussion #1459 Jan 16, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

2 participants