Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] take fetch name #2

Closed
aeosynth opened this issue Feb 1, 2015 · 4 comments
Closed

[npm] take fetch name #2

aeosynth opened this issue Feb 1, 2015 · 4 comments

Comments

@aeosynth
Copy link
Contributor

aeosynth commented Feb 1, 2015

the fetch npm name has been offered by @andris9, and github/fetch is using whatwg-fetch.

@bitinn
Copy link
Collaborator

bitinn commented Feb 1, 2015

Ah thx, i saw that, but decided to leave it be, given it's quite easy to find node-fetch anyway :)

Though if Andris isn't working on fetch anymore, a pull request to clarify module status in readme would be good, so people don't need to figure out if fetch follows whatwg.

@bitinn bitinn closed this as completed Feb 1, 2015
@aeosynth
Copy link
Contributor Author

aeosynth commented Feb 1, 2015

it's your decision, but the use of node is discouraged:

https://docs.npmjs.com/files/package.json:

  • Don't put "js" or "node" in the name. It's assumed that it's js, since you're writing a package.json file, and you can specify the engine using the "engines" field. (See below.)

with iojs gaining popularity, node is slightly anachronistic

@bitinn
Copy link
Collaborator

bitinn commented Feb 1, 2015

hopefully this module will be compatible with iojs without change, if not I will need to look into it in the future.

node-fetch is in a special position where whatwg spec isn't stable yet, and it splits between client-side and server-side (since npm is runtime agnostic, but runtime has different strength and weakness), so I feel ok violating npm best practice :)

@caub
Copy link

caub commented Oct 3, 2017

it would be much easier to use the name fetch on npm

I imagine many people make the mistake, or didn't find this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants