Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should v2 change default highWaterMark value? Alternatives? #248

Closed
bitinn opened this issue Mar 9, 2017 · 1 comment
Closed

Should v2 change default highWaterMark value? Alternatives? #248

bitinn opened this issue Mar 9, 2017 · 1 comment

Comments

@bitinn
Copy link
Collaborator

bitinn commented Mar 9, 2017

If users are writing isomorphic apps, they are quite likely unaware of a major difference of backpressure limit between node-fetch (16kb, as set by nodejs) and browser fetch (at least 1mb, not consistent across browsers).

highWaterMark is basically a signal to upstream whether it should continue to push data (thus cause downstream to store more data in memory).

I wonder if we should raise this limit to 1MB. Though as I wrote many times before, eventually some users will push it to the limit and encounter the same problem.

So it's a problem difficult to troubleshoot by endusers without knowing the existence of such problem beforehand.

What do you think we should do?

related to #151.

@bitinn
Copy link
Collaborator Author

bitinn commented Mar 9, 2017

Note that it's also documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants