Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for node-fetch v3.x #489

Closed
TimothyGu opened this issue Jul 22, 2018 · 5 comments
Closed

Update dependencies for node-fetch v3.x #489

TimothyGu opened this issue Jul 22, 2018 · 5 comments

Comments

@TimothyGu
Copy link
Collaborator

TimothyGu commented Jul 22, 2018

After #488 we will have two packages (nyc, whatwg-url) pinned to an older version due to the fact that the new version does not support Node.js v4.x, and another one (url-search-params) required only for Node.js v4.x as newer versions of Node.js support URLSearchParams. We should update the list of dependencies for node-fetch v3.x, which will drop compatibility for Node.js v4.x.

@TimothyGu TimothyGu added this to the Version 3.0.0 milestone Jul 22, 2018
@bitinn
Copy link
Collaborator

bitinn commented Jul 22, 2018 via email

@realityking
Copy link

According to the docs URLSearchParams was only added in Node.js 7.5, the polyfill would still be required when the minimum version is Node.js 6.

@TimothyGu
Copy link
Collaborator Author

@realityking It’s been backported to v6.x (see https://github.com/nodejs/node/pull/17365)… the docs just need to be updated to reflect that

@jimmywarting
Copy link
Collaborator

Are we going to remove the dependencies and simply just use the builtin?

import { URL, URLSearchParams } from 'url'

@Richienb
Copy link
Member

Richienb commented Sep 8, 2019

The dependencies are updated in 3.x

@Richienb Richienb closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants