New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for node-fetch v3.x #489
Labels
Comments
Oh god, I guess it’s what we have to do, thx for working on this!
(From my phone)
… On Jul 22, 2018, at 13:41, Timothy Gu ***@***.***> wrote:
After #488 we will have two packages (nyc, whatwg-url) pinned to an older version due to the fact that the new version does not support Node.js v4.x, and another one (url-search-params) required only for Node.js v4.x as newer versions of whatwg-url support URLSearchParams. We should update the list of dependencies for node-fetch v3.x, which will drop compatibility for Node.js v4.x.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
According to the docs URLSearchParams was only added in Node.js 7.5, the polyfill would still be required when the minimum version is Node.js 6. |
@realityking It’s been backported to v6.x (see https://github.com/nodejs/node/pull/17365)… the docs just need to be updated to reflect that |
Are we going to remove the dependencies and simply just use the builtin? import { URL, URLSearchParams } from 'url' |
The dependencies are updated in 3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #488 we will have two packages (nyc, whatwg-url) pinned to an older version due to the fact that the new version does not support Node.js v4.x, and another one (url-search-params) required only for Node.js v4.x as newer versions of Node.js support URLSearchParams. We should update the list of dependencies for node-fetch v3.x, which will drop compatibility for Node.js v4.x.
The text was updated successfully, but these errors were encountered: