Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass request timeout on redirect #612

Closed
bitinn opened this issue Apr 25, 2019 · 0 comments · Fixed by #615
Closed

Pass request timeout on redirect #612

bitinn opened this issue Apr 25, 2019 · 0 comments · Fixed by #615
Labels
bug Node-specific

Comments

@bitinn
Copy link
Collaborator

bitinn commented Apr 25, 2019

It seems we forgot to pass request.timeout on redirect:

https://github.com/bitinn/node-fetch/blob/master/src/index.js#L147-L156

And for some reasons, we never got around to merge this PR:

#452

Even though we have AbortSignal support, should still fix it for timeout users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Node-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass custom timeout to subsequent requests node-fetch/node-fetch
1 participant
@bitinn