Return array of File Objects

[blueelvis]

Currently, formidable does not return an array of File Objects in the JSON format if only a single file upload takes place. This makes breaks the logic of counting the number of files.

Modified code which corrects this -

lib\incoming_form.js

if (cb) {
    var fields = {}, files = {};
    this
      .on('field', function(name, value) {
        fields[name] = value;
      })
      .on('file', function(name, file) {
        if (this.multiples) {
          if (files[name]) {
            if (!Array.isArray(files[name])) {
              files[name] = [files[name]];
            }
            files[name].push(file);
          } else {
            files[name] = [file];
          }
        } else {
          files[name] = [file];
        }
      })
      .on('error', function(err) {
        cb(err, fields, files);
      })
      .on('end', function() {
        cb(null, fields, files);
      });
  }

[tunnckoCore]

Thanks! I always thought that is not so comfort too

[tunnckoCore]

Maybe #315 is fix.

[DylanPiercey]

Fields can also have multiples, is that a consideration here?

[blueelvis]

@tunnckoCore - Can I submit a PR?

[kornelski]

Hi! This is a common request, so it's definitely good to add it.

However, please be careful with the implementation.

It's cumbersome and potentially dangerous to have a field that can be an object or an array. It requires the application to check every time, and the application may be tricked into mishandling files if an attacker submits 2 files when the app expects only 1.

So don't reuse any existing fields. Add a new one, which is array-only.

[tunnckoCore]

Just merged #380. We need to add this.multiples check to it too.

[GrosSacASac]

npm i node-formidable/formidable#3.x