Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not change "uploadDir" via constructor option #595

Closed
ghost opened this issue Apr 2, 2020 · 7 comments · Fixed by #591
Closed

can not change "uploadDir" via constructor option #595

ghost opened this issue Apr 2, 2020 · 7 comments · Fixed by #591
Labels

Comments

@ghost
Copy link

ghost commented Apr 2, 2020

In the current version of library (2.0.0-canary.20200226.1) option uploadDir in the constructor is ignored. Instead of this option, field this.uploadDir takes value from itself or set default value (temp dir)
this part
and
this part

For now to fix this problem you should set form.uploadDir = 'your path'

@ghost ghost added the bug Something isn't working label Apr 2, 2020
@auto-comment
Copy link

auto-comment bot commented Apr 2, 2020

Thank you for raising this issue! We will try and get back to you as soon as possible. Please make sure you format it properly, followed our code of conduct and have given us as much context as possible.
/cc @tunnckoCore @GrosSacASac

@tunnckoCore
Copy link
Member

Yea, I've seen that problem and fixed it in master. Try installing master for now until publish a npm version.

@tunnckoCore
Copy link
Member

tunnckoCore commented Apr 2, 2020

Oh wait, it's in #591 ... I paused it, because for some reason tests locally don't run...

@tunnckoCore
Copy link
Member

tunnckoCore commented Apr 2, 2020

@DJ-MATAIL, Please try installing file-renaming branch.
I guess npm i node-formidable/formidable#file-renaming was the way.

Also, if you clone the branch and try to run the tests with yarn test and they don't halt... would be very valuable and very appreciated. :)

@tunnckoCore
Copy link
Member

@DJ-MATAIL canary.20200402.1 is published.

@ghost
Copy link
Author

ghost commented Apr 2, 2020

It was resolved. Thank you!

@tunnckoCore
Copy link
Member

Thanks for reminding me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant