Add support for array-like fields #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic support for array-like fields when the 'multiples' option is enabled and field is suffixed with "[]".
|
@samholmes sorry, I just merged #380. :) |
tunnckoCore
added a commit
that referenced
this pull request
Nov 28, 2019
|
Please try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic feature to add, and I know it's a "feature", but allow me to state my case.
One may not want this feature (I can argue that most would, but that's just my opinion), and currently when someone wants this feature, they must write their own parse function. However, with this feature, one could write their own parse function if they don't want this feature (or they could just not enable it via the multiples option). So, either way, the default parse method could (and should IMO) include this feature; if someone doesn't want this feature they can write their own parse function.
Besides, why would someone ever complain about this feature when it's so unobtrusive? It would only if someone wanted their name had the
[]suffix at the end for whatever reason (maybe they like boxes or something).I see no argument against this feature, so let's solve this issue: #33