Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom (querystring) parsing module(s) #391

Closed
tunnckoCore opened this issue Sep 9, 2016 · 3 comments · Fixed by #545
Closed

Allow passing custom (querystring) parsing module(s) #391

tunnckoCore opened this issue Sep 9, 2016 · 3 comments · Fixed by #545

Comments

@tunnckoCore
Copy link
Member

tunnckoCore commented Sep 9, 2016

By default to use querystring, but it can be done to use qs passed from options for example. This would be the easiest fix for the querystring issues.

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jan 16, 2017

What irony, haha.

Actually, I'm thinking that for that about months and that Octet and JSON parsers could be done better.

@felixge actually why they are "custom streams" e.g. event emitters with .write and .end methods? Because the need for more stable 0.10 support?

And actually what you think about dropping Node < 4 support? /cc @felixge @pornel @badeball

@felixge
Copy link
Collaborator

felixge commented Jan 16, 2017

@tunnckoCore I don't know what you mean by `custom streams. When I wrote this module, these were the only kind of streams that existed ;).

I'm also the wrong person to ask about dropping Node < 4 support. I don't know if that's a reasonable thing to do these days.

@tunnckoCore
Copy link
Member Author

dropping < 4 support will allow using more stable and "real" streams using the stream module instead of eventemitter.

i said "custom streams", because streams are event emitters, but eventemitters are not streams. and so i believe these parsers can be transform or write streams.

@tunnckoCore tunnckoCore changed the title Allow passing custom querystring parsing module Allow passing custom (querystring) parsing module(s) Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants