Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make opts.filename from #591 work with opts.keepExtensions #597

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

tunnckoCore
Copy link
Member

@tunnckoCore tunnckoCore commented Apr 2, 2020

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
@auto-comment
Copy link

auto-comment bot commented Apr 2, 2020

Thank you for raising your pull request. Please make sure again that you have followed our contributing guidelines and the code of conduct. We will review it as soon as possible.
/cc @tunnckoCore @GrosSacASac

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #597 into master will decrease coverage by 1.11%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   83.93%   82.81%   -1.12%     
==========================================
  Files          14       14              
  Lines         635      646      +11     
  Branches      104      107       +3     
==========================================
+ Hits          533      535       +2     
- Misses         93      101       +8     
- Partials        9       10       +1     
Impacted Files Coverage Δ
src/Formidable.js 73.23% <29.41%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37877b4...5cb4b65. Read the comment docs.

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
@tunnckoCore tunnckoCore merged commit d33bd0c into master Apr 2, 2020
@tunnckoCore tunnckoCore deleted the keep-extensions-work-with-file-rename branch April 2, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant