made live edit work with multiple windows

fixed --start-brk
node-inspector · Jul 30, 2010 · dc45824 · dc45824
1 parent b27b64a
commit dc45824
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/bin/inspector.js b/bin/inspector.js
@@ -15,7 +15,7 @@ process.argv.forEach(function(arg) {
           break;
         case '--start-brk':
           options.file = parts[1];
-          brk = true;
+          options.brk = true;
           break;
         case '--agent-port':
           options.webPort = parseInt(parts[1], 10);

diff --git a/front-end/node/Debugger.js b/front-end/node/Debugger.js
@@ -65,8 +65,8 @@ WebInspector.nodeDebugger = (function() {
       socket.onopen = function() {
         console.log('socket open');
         WebInspector.debuggerWasEnabled();
-        sendRequest('scripts', {
+        debugr.getScripts();
-          arguments: { includeSource: true, types: 4 }});
+        debugr.listBreakpoints();
       };
     },
     close: function() {
@@ -78,6 +78,10 @@ WebInspector.nodeDebugger = (function() {
       list.push(callback);
       listeners[event] = list;
     },
+    getScripts: function() {
+      sendRequest('scripts', {
+        arguments: { includeSource: true, types: 4 }});
+    },
     setBreakpoint: function(callId, sourceID, line, enabled, condition) {
       var bp = breakpoints[sourceID + ':' + line];
       if(bp) {

diff --git a/front-end/node/InspectorFrontendHostStub.js b/front-end/node/InspectorFrontendHostStub.js
@@ -99,8 +99,7 @@ WebInspector.InspectorFrontendHostStub = function()
     msg.body.forEach(function(s) {
       WebInspector.parsedScriptSource(s.id, s.name, s.source, s.lineOffset, 0);
     });
-    debugr.listBreakpoints();
+    if (!msg.running && !WebInspector.panels.scripts._paused) {
-    if (!msg.running) {
       debugr.getBacktrace();
     }
   });
@@ -212,7 +211,13 @@ WebInspector.InspectorFrontendHostStub = function()
     }
   });
   debugr.on('changelive', function(msg) {
-    WebInspector.didEditScriptSource(msg.callId.id, msg.success, msg.message ||msg.callId.body);
+    if (msg.callId) {
+      WebInspector.didEditScriptSource(msg.callId.id, msg.success, msg.message ||msg.callId.body);
+    }
+    else {
+      WebInspector.panels.scripts.reset();
+      WebInspector.nodeDebugger.getScripts();
+    }
   });
   debugr.on('frame', function(msg) {
 

diff --git a/readme.md b/readme.md
@@ -89,7 +89,6 @@ This is alpha quality code, so use at your own risk:
 
 * save application settings
 * debug-agent needs a lot of work
-* try out live edit
 * profiler panel
 
 ## Thanks