Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes immediate WS disconnect error with NodeJS v6.3+ #932

Closed
wants to merge 1 commit into from

Conversation

tautologistics
Copy link

@tautologistics tautologistics commented Oct 3, 2016

Fixes small error in handling error condition vs. having an actual native module to return:

TypeError: Cannot read property 'ref' of undefined
    at InjectorClient.<anonymous> (/usr/lib/node_modules/node-inspector/lib/InjectorClient.js:111:22)
    at /usr/lib/node_modules/node-inspector/lib/DebuggerClient.js:121:7
    at Object.value (/usr/lib/node_modules/node-inspector/lib/callback.js:23:20)
    at Debugger._processResponse (/usr/lib/node_modules/node-inspector/lib/debugger.js:95:21)
    at Protocol.execute (_debugger.js:121:14)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at TCP.onread (net.js:543:20)

Reference issues:

@samuelcastro
Copy link

Is this gonna be merged?

@MadOgre
Copy link

MadOgre commented Oct 26, 2016

Not sure if the maintainers check this repo anymore. Maybe time for a fork.

@pospi
Copy link

pospi commented Oct 27, 2016

I've manually applied this fix and I now get Error: No NativeModule in target scope in the debugger- no source files, still doesn't appear to work.

@samuelcastro
Copy link

I've just decided to use native inspector with: node --inspect index.js and it's working nicely. (https://nodejs.org/api/debugger.html#debugger_v8_inspector_integration_for_node_js)

@pospi
Copy link

pospi commented Oct 28, 2016

heh, likewise...

On Fri, Oct 28, 2016 at 12:03 PM, Samuel Castro notifications@github.com
wrote:

I've just decided to use native inspector with: node --inspect index.js
and it's working nicely. (https://nodejs.org/api/
debugger.html#debugger_v8_inspector_integration_for_node_js)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAatJKXtUUl-J3nrFGe5GjlEyrnBLLXgks5q4VfZgaJpZM4KMpi-
.

@grantgeorge
Copy link

@samuelcastro @pospi do you guys run into the issue where it opens a new window for the inspector whenever your server reloads? kind of a pain in the but using the --inspect flag for me

@zignd
Copy link

zignd commented Mar 12, 2017

@samuelcastro thanks for the tip!

The --inspect flag on the Node.js runtime is a great alternative!

@hustxiaoc
Copy link
Collaborator

Fixed in node-inspector@1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants