Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return socket from createConnection and add type for createConnection #113

Merged
merged 1 commit into from Aug 4, 2023

Conversation

nabeelbukhari
Copy link
Contributor

@nabeelbukhari nabeelbukhari commented Aug 3, 2023

As per http.agent createConnection method, the method should return a socket but I found that current implemenation of createConnection for Agent doesn't return socket.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

Description of change

Return socket from createConnection and add type for createConnection

@nabeelbukhari
Copy link
Contributor Author

@fengmk2 Can you please help review this PR?

@fengmk2 fengmk2 changed the title Return socket from createConnection and add type for createConnection feat: Return socket from createConnection and add type for createConnection Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #113 (ee82816) into master (2092714) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          223       224    +1     
  Branches        43        43           
=========================================
+ Hits           223       224    +1     
Files Changed Coverage Δ
lib/agent.js 100.00% <100.00%> (ø)
lib/https_agent.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit c7c1e93 into node-modules:master Aug 4, 2023
8 checks passed
@fengmk2
Copy link
Member

fengmk2 commented Aug 4, 2023

4.4.0

@fengmk2
Copy link
Member

fengmk2 commented Aug 4, 2023

@nabeelbukhari Thanks!

@nabeelbukhari nabeelbukhari deleted the fix-create-connection branch August 5, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants