Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep urllib2 request with Type parameter #432

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 14, 2023

await urllib.request<User>(url)

```ts
await urllib.request<User>(url)
```
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #432 (8afe64b) into master (0abdf2d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files           8        8           
  Lines        1212     1212           
  Branches      230      230           
=======================================
  Hits         1210     1210           
  Misses          2        2           
Impacted Files Coverage Δ
src/HttpClient.ts 99.83% <100.00%> (ø)
src/Response.ts 100.00% <100.00%> (ø)
src/index.ts 97.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit 12f169e into master Jan 14, 2023
@fengmk2 fengmk2 deleted the fix-support-request-with-T branch January 14, 2023 08:54
fengmk2 pushed a commit that referenced this pull request Jan 14, 2023
[skip ci]

## [3.10.1](v3.10.0...v3.10.1) (2023-01-14)

### Bug Fixes

* keep urllib2 request with Type parameter ([#432](#432)) ([12f169e](12f169e))
@github-actions
Copy link

🎉 This PR is included in version 3.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant