Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tracing on diagnostics_channel #452

Merged
merged 19 commits into from
Jun 15, 2023
Merged

feat: support tracing on diagnostics_channel #452

merged 19 commits into from
Jun 15, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 11, 2023 •
edited

Auto retry on socket error
closes #454

@fengmk2 fengmk2 added the enhancement New feature or request label Jun 11, 2023
@socket-security
Copy link

socket-security bot commented Jun 11, 2023 •
edited

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
cross-env 🆕 7.0.3 environment +0 29.1 kB kentcdodds
vitest ⬆️ 0.31.4...0.32.0 None +7/-7 1.83 MB oreanno

🚮 Removed packages: @vitest/coverage-c8@0.29.8

Footnotes

  1. https://docs.socket.dev ↩

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 11, 2023
View reviewed changes
examples/timing.cjs Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Jun 11, 2023 •
edited

Codecov Report

Merging #452 (da5e5c5) into master (3583219) will decrease coverage by 0.04%.
The diff coverage is 98.40%.

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   99.52%   99.48%   -0.04%     
==========================================
  Files           8        8              
  Lines        1253     1358     +105     
  Branches      242      240       -2     
==========================================
+ Hits         1247     1351     +104     
- Misses          6        7       +1
Impacted Files Coverage Δ
src/HttpClient.ts 99.25% <96.49%> (-0.27%) ⬇️
src/Request.ts 100.00% <100.00%> (ø)
src/Response.ts 100.00% <100.00%> (ø)
src/diagnosticsChannel.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (+1.92%) ⬆️
src/symbols.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 marked this pull request as ready for review June 12, 2023 02:21
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 12, 2023

#275

@fengmk2 fengmk2 mentioned this pull request Jun 12, 2023
Closed
@fengmk2 fengmk2 marked this pull request as draft June 12, 2023 04:43
fengmk2
fengmk2 commented Jun 12, 2023
View reviewed changes
src/Request.ts Outdated Show resolved Hide resolved
@fengmk2 fengmk2 marked this pull request as ready for review June 15, 2023 06:13
@fengmk2 fengmk2 merged commit 416b2ca into master Jun 15, 2023
20 of 22 checks passed
@fengmk2 fengmk2 deleted the diagnostics_channel branch June 15, 2023 06:40
fengmk2 pushed a commit that referenced this pull request Jun 15, 2023
@semantic-release-bot
Release 3.17.0
607ae8a 
[skip ci]

## [3.17.0](v3.16.1...v3.17.0) (2023-06-15)

### Features

* support tracing on diagnostics_channel ([#452](#452)) ([416b2ca](416b2ca))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retry on socket error
1 participant
@fengmk2