Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tshy to support commonjs and esm both #468

Merged
merged 4 commits into from
Sep 14, 2023
Merged

feat: use tshy to support commonjs and esm both #468

merged 4 commits into from
Sep 14, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 14, 2023

@fengmk2 fengmk2 added the enhancement New feature or request label Sep 14, 2023
},
"types": "./src/esm/index.d.ts",
"main": "./src/cjs/index.js",
"typings": "./dist/commonjs/index.d.ts",
Copy link
Member Author

@fengmk2 fengmk2 Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确保 tsconfig module 配置为 commonjs 的老应用可以依赖

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #468 (1099398) into master (166403f) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           8        8           
  Lines        1411     1411           
  Branches      253      253           
=======================================
  Hits         1406     1406           
  Misses          5        5           
Files Changed Coverage Δ
src/HttpClient.ts 99.57% <100.00%> (ø)
src/Request.ts 100.00% <100.00%> (ø)
src/diagnosticsChannel.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/utils.ts 98.72% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socket-security
Copy link

socket-security bot commented Sep 14, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tshy 1.0.0-3 filesystem, shell +12 3.07 MB isaacs

@fengmk2 fengmk2 merged commit b2576c0 into master Sep 14, 2023
22 checks passed
@fengmk2 fengmk2 deleted the tshy branch September 14, 2023 06:13
fengmk2 pushed a commit that referenced this pull request Sep 14, 2023
[skip ci]

## [3.19.0](v3.18.1...v3.19.0) (2023-09-14)

### Features

* use tshy to support commonjs and esm both ([#468](#468)) ([b2576c0](b2576c0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant