fix: make sure kClients exists on Agent #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fengmk2
commented
Dec 22, 2023
fengmk2
commented
> TypeError: clients is not iterable
fengmk2
commented
Dec 22, 2023
| const poolStatsMap: Record<string, PoolStat> = {}; | ||
| if (!clients) { |
There was a problem hiding this comment.
reapeat
> clients = undefined
undefined
> for (const [ key, ref ] of clients) {}
Uncaught TypeError: clients is not iterable
> clients = null
null
> for (const [ key, ref ] of clients) {}
Uncaught TypeError: clients is not iterable
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 98.79% 98.67% -0.13%
==========================================
Files 10 10
Lines 1583 1586 +3
Branches 272 274 +2
==========================================
+ Hits 1564 1565 +1
- Misses 19 21 +2 ☔ View full report in Codecov by Sentry. |
fengmk2
pushed a commit
that referenced
this pull request
Dec 22, 2023
[skip ci] ## [3.22.1](v3.22.0...v3.22.1) (2023-12-22) ### Bug Fixes * make sure kClients exists on Agent ([#482](#482)) ([574bd47](574bd47))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.