fix: use querystring to stringify data #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
force-pushed
the
fix/array_querystring
branch
from
eb2ab0b
to
161b5d1
Compare
|
单测挂了 |
fengmk2
reviewed
Feb 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 10 10
Lines 1597 1595 -2
Branches 273 271 -2
==========================================
- Hits 1576 1574 -2
Misses 21 21 ☔ View full report in Codecov by Sentry. |
killagu
commented
Feb 20, 2024
| @@ -37,7 +38,7 @@ describe('options.data.test.ts', () => { | |||
| assert.equal(response.data.method, 'GET'); | |||
| assert(response.url.startsWith(_url)); | |||
| assert(!response.redirected); | |||
| assert.equal(response.data.url, '/?sql=SELECT+*+from+table&data=%E5%93%88%E5%93%88&c=2222&d=1111&e=e%28%29+%7B%0A++++++++++return+%22%22%3B%0A++++++++%7D&f=true'); | |||
| assert.equal(response.data.url, '/?sql=SELECT%20*%20from%20table&data=%E5%93%88%E5%93%88&b=&c=2222&d=1111&e=&f=true&g=a&g=b'); | |||
There was a problem hiding this comment.
value 不能序列化的 key 都保留下来了。
killagu
commented
Feb 20, 2024
fengmk2
pushed a commit
that referenced
this pull request
Feb 20, 2024
[skip ci] ## [3.22.3](v3.22.2...v3.22.3) (2024-02-20) ### Bug Fixes * use querystring to stringify data ([#489](#489)) ([ee9a786](ee9a786))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.