workaround for socket hang up

nock · Jun 5, 2017 · 5db4fa0 · 5db4fa0
1 parent f984668
commit 5db4fa0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/lib/recorder.js b/lib/recorder.js
@@ -337,22 +337,20 @@ function record(rec_options) {
           }
           bodyChunks.push(data);
         }
-        oldWrite.call(req, data);
+        oldWrite.apply(req, arguments);
       }
     };
 
     // in Node 8, res.end() does not call res.write() directly
     if (semver.satisfies(process.version, '>=8')) {
       var oldEnd = req.end;
-      req.end = function(data, encoding, callback) {
-        if ('undefined' !== typeof(data)) {
-          if (data) {
-            debug(thisRecordingId, 'new', proto, 'body chunk');
-            if (! Buffer.isBuffer(data)) {
-              data = new Buffer(data, encoding);
-            }
-            bodyChunks.push(data);
+      req.end = function(data, encoding) {
+        if (data) {
+          debug(thisRecordingId, 'new', proto, 'body chunk');
+          if (! Buffer.isBuffer(data)) {
+            data = new Buffer(data, encoding);
           }
+          bodyChunks.push(data);
         }
         oldEnd.apply(req, arguments);
       };

diff --git a/tests/test_recorder.js b/tests/test_recorder.js
@@ -280,8 +280,7 @@ test('records nonstandard ports', function(t) {
 
   //  Create test http server and perform the tests while it's up.
   var testServer = http.createServer(function(req, res) {
-    res.write(RESPONSE_BODY);
-    res.end();
+    res.end(RESPONSE_BODY);
   }).listen(8081, function(err) {
 
     t.equal(err, undefined);
@@ -731,8 +730,7 @@ test('works with clients listening for readable', {skip: process.env.AIRPLANE},
 
   //  Create test http server and perform the tests while it's up.
   var testServer = http.createServer(function(req, res) {
-    res.write(RESPONSE_BODY);
-    res.end();
+    res.end(RESPONSE_BODY);
   }).listen(8081, function(err) {
 
     // t.equal(err, undefined);