Resolved Issue #804 #862
Resolved Issue #804 #862
Conversation
There was a problem hiding this comment.
@dcstone09 Thanks for this! Instead of putting your test in a new file, please add to tests/test_intercept.js.
|
@ianwsperber Thanks, I've moved the test over. |
tests/test_intercept.js
Outdated
| @@ -196,6 +196,23 @@ test("reply should throw on error on the callback", function(t) { | |||
| req.end(); | |||
| }); | |||
|
|
|||
| test('reply should not cause an error on header conflict', function (t) { | |||
| @@ -73,6 +73,7 @@ Interceptor.prototype.reply = function reply(statusCode, body, rawHeaders) { | |||
|
|
|||
| if (this.scope._defaultReplyHeaders) { | |||
| headers = headers || {}; | |||
| headers = common.headersFieldNamesToLowerCase(headers); | |||
There was a problem hiding this comment.
@iangreenleaf This corrects the throwing conflict exception. Do we have test cases for testing overrides of the default headers when strings are loosely matching ('SomEthing' ==='something')?
There was a problem hiding this comment.
@moaxaca Not sure off the top of my head
There was a problem hiding this comment.
@ianwsperber This test could over that.
tests/test_intercept.js
Outdated
| }); | ||
| }); | ||
|
|
||
| t.end() |
There was a problem hiding this comment.
@dcstone09 Before ending the test, could we actually make a request to http://www.website.com/search?IMO that would be a more complete assertion of the expected behavior.
|
@ianwsperber The test case has been updated |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Hello, I think this fixes #804. I am not sure where to put my test case exactly. Any feedback would be great thanks.