Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(readme): Documentation Update for activate, isActive, restore methods. #1002

Merged
merged 4 commits into from
Oct 22, 2017

Conversation

rash805115
Copy link
Contributor

@gr2m Please review.

PR to fix Issue #997

PR contains documentation update for:

  1. restore()
  2. activate()
  3. isActive()

@coveralls
Copy link

coveralls commented Oct 22, 2017

Coverage Status

Coverage remained the same at 92.671% when pulling 86d5a06 on rash805115:master into bd38736 on node-nock:master.

@gr2m gr2m self-assigned this Oct 22, 2017
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you 👍

@gr2m gr2m merged commit f22dcc3 into nock:master Oct 22, 2017
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants