Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple proposal of documentation for stop recording #1013

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Conversation

hems
Copy link
Contributor

@hems hems commented Nov 1, 2017

Proposing documentation for "stop recording" feature, closes #659

Proposing documentation for "stop recording" feature, as per issue nock#659
@gr2m
Copy link
Member

gr2m commented Nov 1, 2017

Thanks

Just fyi I edited as per issue #659 to closes #659 in your pull request description, so that the issue gets closed automatically once we merged the PR, see https://help.github.com/articles/closing-issues-using-keywords

@gr2m gr2m merged commit 4f83d90 into nock:master Nov 1, 2017
@hems
Copy link
Contributor Author

hems commented Nov 1, 2017

thanks

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants