Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example.com/unmocked no longer returns default page #1066

Merged
merged 1 commit into from Feb 20, 2018

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Feb 20, 2018

changing it to example.com/?unmocked fixes the problem. But I really don’t think it’s a good idea we rely on outside websites for our tests in the first place 🤔

@gr2m
Copy link
Member Author

gr2m commented Feb 20, 2018

thanks for the quick review @n30n0v! The failing CI tests are unrelated, would be nice to get them green again, I'll try to have a look this week

@gr2m gr2m merged commit 68df807 into master Feb 20, 2018
@petersolopov
Copy link
Member

petersolopov commented Feb 20, 2018

I know, I've looked at falling test. It seems something changed in third party libs like zombie or browserify

@gr2m gr2m deleted the fix-example-com-unmocked branch February 20, 2018 06:35
@gr2m
Copy link
Member Author

gr2m commented Feb 20, 2018

@n30n0v do you know why we test with browserify in the first place? My understanding is that nock does not support usage in Browsers?

@petersolopov
Copy link
Member

@gr2m I guess so. I've always thought that nock doesn't work with browsers.

@gr2m
Copy link
Member Author

gr2m commented Feb 20, 2018

let’s kick then, this thing is hard enough to maintain, if there are no objections with in a week, let’s kick it out. I'll start a PR

@gr2m gr2m mentioned this pull request Feb 21, 2018
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants