Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #947 #948

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Fix for #947 #948

merged 1 commit into from
Jul 14, 2017

Conversation

martinkuba
Copy link
Contributor

The failing test was checking that a call to www.amazon.com was returning data. This URL does not return any data any longer - changed it to one that does.

@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage increased (+0.6%) to 92.654% when pulling a2f170f on martinkuba:master into 35c76e3 on node-nock:master.

This was referenced Jul 13, 2017
@0xcaff
Copy link

0xcaff commented Jul 14, 2017

lgtm

[drone@drone tmp]$ curl --verbose www.amazon.com
* Rebuilt URL to: www.amazon.com/
*   Trying 104.95.239.148...
* TCP_NODELAY set
* Connected to www.amazon.com (104.95.239.148) port 80 (#0)
> GET / HTTP/1.1
> Host: www.amazon.com
> User-Agent: curl/7.54.1
> Accept: */*
> 
< HTTP/1.1 302 Moved Temporarily
< Server: AkamaiGHost
< Content-Length: 0
< Location: https://www.amazon.com/
< Date: Fri, 14 Jul 2017 00:29:17 GMT
< Connection: keep-alive
< 
* Connection #0 to host www.amazon.com left intact

@ianwsperber
Copy link
Contributor

Awesome @martinkuba! Thanks for stepping up again to help.

@ianwsperber ianwsperber merged commit 612388e into nock:master Jul 14, 2017
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants