Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Match Logging #954

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Improve Match Logging #954

merged 1 commit into from
Sep 19, 2017

Conversation

technicallyerik
Copy link

Currently, matching logging does not include the method or path of the request. I have added these to make debugging non-matches easier.

Currently, matching logging does not include the method or path of the request.  I have added these to make debugging non-matches easier.
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage remained the same at 92.654% when pulling 8288ece on technicallyerik:logging-improvements into 8da9ee0 on node-nock:master.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, thanks 💐

@gr2m gr2m merged commit 93341d3 into nock:master Sep 19, 2017
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants